Skip to content

Put shards failure under a cap flag #131371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2025
Merged

Put shards failure under a cap flag #131371

merged 5 commits into from
Jul 16, 2025

Conversation

smalyshev
Copy link
Contributor

No description provided.

@smalyshev smalyshev changed the title Fail shards cap Put shards failure under a cap flag Jul 16, 2025
@smalyshev smalyshev marked this pull request as ready for review July 16, 2025 16:38
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@dnhatn
Copy link
Member

dnhatn commented Jul 16, 2025

Since the new behavior in serverless, which does not have CCS, perfectly matches the behavior of the search API, do we still want to disable it in serverless?

@smalyshev smalyshev requested a review from alex-spies July 16, 2025 16:47
@smalyshev smalyshev added auto-backport Automatically create backport pull requests when merged v8.19.1 v9.1.1 labels Jul 16, 2025
alex-spies
alex-spies approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @smalyshev !

@dnhatn dnhatn added the test-release Trigger CI checks against release build label Jul 16, 2025
dnhatn
dnhatn approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might need to adjust some tests as they can fail in the release builds. Thanks Stas!

@smalyshev smalyshev merged commit 0411940 into elastic:main Jul 16, 2025
34 checks passed
@smalyshev
Copy link
Contributor Author

smalyshev commented Jul 16, 2025 •
edited
Loading

Oops noticed the test-release thing too late but I made the run with the feature disabled and updated the test, so I think it should be ok.

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.1 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131371

@smalyshev smalyshev mentioned this pull request Jul 16, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 16, 2025
@smalyshev
Put shards failure under a cap flag (elastic#131371)
924d69b 
* Put shards failure under a cap flag

(cherry picked from commit 0411940)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 16, 2025
@smalyshev
Put shards failure under a cap flag (elastic#131371)
1a30166 
* Put shards failure under a cap flag

(cherry picked from commit 0411940)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
@smalyshev smalyshev mentioned this pull request Jul 16, 2025
Merged
@smalyshev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

@smalyshev smalyshev deleted the fail-shards-cap branch July 16, 2025 19:18
elasticsearchmachine pushed a commit that referenced this pull request Jul 16, 2025
@smalyshev
Put shards failure under a cap flag (#131371) (#131388)
8a8845d 
* Put shards failure under a cap flag

(cherry picked from commit 0411940)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
elasticsearchmachine pushed a commit that referenced this pull request Jul 16, 2025
@smalyshev
Put shards failure under a cap flag (#131371) (#131389)
936fca2 
* Put shards failure under a cap flag

(cherry picked from commit 0411940)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 18, 2025
@smalyshev
Revert "Put shards failure under a cap flag (elastic#131371)"
b1f20cf 
This reverts commit 0411940.
smalyshev added a commit that referenced this pull request Jul 18, 2025
@smalyshev
Revert "Put shards failure under a cap flag (#131371)" (#131542)
be2f024 
This reverts commit 0411940.
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 18, 2025
@smalyshev
Revert "Put shards failure under a cap flag (elastic#131371)" (elasti…
6c70dcd 
…c#131542)

This reverts commit 0411940.

(cherry picked from commit be2f024)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 18, 2025
@smalyshev
Revert "Put shards failure under a cap flag (elastic#131371)" (elasti…
b9d740c 
…c#131542)

This reverts commit 0411940.

(cherry picked from commit be2f024)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
elasticsearchmachine pushed a commit that referenced this pull request Jul 18, 2025
@smalyshev
[9.1] Revert "Put shards failure under a cap flag (#131371)" (#131542) (
654dec2 
#131552)

* Revert "Put shards failure under a cap flag (#131371)" (#131542)

This reverts commit 0411940.

(cherry picked from commit be2f024)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java

* fix caps
elasticsearchmachine pushed a commit that referenced this pull request Jul 18, 2025
@smalyshev
Revert "Put shards failure under a cap flag (#131371)" (#131542) (#13…
4b47fd8 
…1553)

This reverts commit 0411940.

(cherry picked from commit be2f024)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

@dnhatn dnhatn dnhatn approved these changes

@alex-spies alex-spies alex-spies approved these changes

@idegtiarenko idegtiarenko Awaiting requested review from idegtiarenko

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-release Trigger CI checks against release build v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smalyshev @elasticsearchmachine @dnhatn @nik9000 @alex-spies